Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 29, 2025

Linked Issue

Closes #4182

Description

Removes all @skeletonlabs/skeleton-common/classes imports and class object assignments from component packages. CSS is now imported separately via CSS files, making these JS imports redundant.

Changes:

  • Removed import * as classes from '@skeletonlabs/skeleton-common/classes' from 456 component files
  • Removed { class: classes.xxx.xxx } / { className: classes.xxx.xxx } objects from mergeProps calls
  • Affected packages: skeleton-react, skeleton-svelte

Before:

import * as classes from '@skeletonlabs/skeleton-common/classes';

const attributes = mergeProps(
  popover.getTriggerProps(),
  { className: classes.popover.trigger },
  rest,
);

After:

const attributes = mergeProps(
  popover.getTriggerProps(),
  rest,
);

AI Disclosure

Use of LLM technology is allowed. We ask for your voluntary disclosure to help inform future Skeleton contribution guidelines.

  • I used AI to generate this pull request

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, task/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changesets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR ready for review.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 29, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2025

⚠️ No Changeset found

Latest commit: 5be1180

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
themes.skeleton.dev Building Building Preview Nov 29, 2025 5:05pm
www.skeleton.dev Error Error Nov 29, 2025 5:05pm

Copilot AI changed the title [WIP] Update to use native layer base for Tailwind Remove @skeletonlabs/skeleton-common/classes imports from component packages Nov 29, 2025
Copilot finished work on behalf of Hugos68 November 29, 2025 17:06
Copilot AI requested a review from Hugos68 November 29, 2025 17:06
@Hugos68 Hugos68 marked this pull request as ready for review November 29, 2025 17:08
@Hugos68 Hugos68 merged commit 3a6f871 into feature/native-base-layer Nov 29, 2025
0 of 2 checks passed
@Hugos68 Hugos68 deleted the copilot/sub-pr-4182 branch November 29, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants