-
-
Notifications
You must be signed in to change notification settings - Fork 373
feature: native base layer #4182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5245df4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@copilot Inspect how I converted the |
Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Hugos68 <[email protected]>
|
@copilot Now please remove all the imports from @skeletonlabs/skeleton-common/classes inside the component packages, you can remove that because the CSS is now imported seperately. |
…ackages (#4184) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Hugos68 <[email protected]>
|
@Hugos68 everything looks good so far. The only thing of note here is that rewriting all our styles does mean we need to do a lot of manual regression testing. Even one small style being off could cause a regression. This will take more time than I have today. But we can continue to review over the next couple days as times allows. |
|
Totally understand that. We need to be very thorough as there were already some instances where to due to specificity differences styles needed slight tweaking to behave like before. I already did a somewhat thorough pass, but you can never be sure enough. |
|
@Hugos68 I've run through the checking styling for all these. There's two small issues to report, both visible on the Toast component docs page:
|
This was already the case, we can fix it in this PR though!
I was not aware, will aim to fix 👍 |
This PR moves our component styles from tailwind utilities to css, this allows us to move away from the
skblayer and use the native@layer basedirectly, this has several benefits, notable ones are:@custom-variant skb(simplification)