Skip to content

Contribute pull request

simon816 edited this page Nov 27, 2013 · 2 revisions

4.4 Pull Requests [Contributing]

Once you are happy with your changes you are ready to submit a pull request. First make sure you have the latest revision on the repository and update your project if neccessary. Please check for errors before sumbitting and also check your feature works as expected.
The format for code that I am using (and have inherited from the original comcraft code) is

  • 4 spaces per indentation - no tabs
  • 256 character word-wrap
  • LF line endings (git should do this for you)
  • No warnings - fix any [Warnings] and [Errors] first

Your commit(s) should breifly describe what you did and should follow how I have done mine (I don't want "Update xyz.java")

Once all is ready, compare your revision and the current mainline revision and submit a pull request. I hope to easily merge it but be ready for any possible discussion first.


Contributing
Home -> Setup, Requirements -> Using MINIJOE -> Using CCMLGen.py -> Pull Requests

Clone this wiki locally