-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[feat] Enable NVFP4 for model weight loading daemon #32398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xuantengh
wants to merge
10
commits into
sgl-project:main
Choose a base branch
from
xuantengh:fast_recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f68c2ca
add nvfp4
xuantengh 121f058
add nvfp4 for weight cache daemon
xuantengh 50f0126
remove unnecessary configs and utils
xuantengh 27f55eb
remove some comments
xuantengh 4913aff
restore the comments
xuantengh 02bcd11
validate nvfp4 quant config
xuantengh ac57fb1
limit diff change region
xuantengh b07bb6a
map quant_method to rebind method
xuantengh 8baf41f
Merge branch 'main' into fast_recovery
liusy58 d62f5b8
Merge branch 'main' into fast_recovery
liusy58 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was sent to the client side to ensure both sides load the weights using the same backend:
https://github.com/xuantengh/sglang/blob/8baf41f1c151f9da02243ec0db8ac083ea1a854f/python/sglang/srt/weight_cache/ipc_loader.py#L388-L401
As different MoE backends post-process the weight tensor (e.g., permute, reorder) into different physical layout, mixing backends will lead to shape mismatch or numeric error.