[feat] Enable NVFP4 for model weight loading daemon - #32398
Open
xuantengh wants to merge 10 commits into
Open
Conversation
xuantengh
requested review from
Alisehen,
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
HaiShaw,
OrangeRedeng,
b8zhong,
ch-wan and
liusy58
as code owners
July 25, 2026 12:43
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
|
I will review this PR as soon as possible |
QiuMike
self-requested a review
July 31, 2026 05:36
liusy58
reviewed
Jul 31, 2026
| self.module_attrs: Dict[str, Dict[str, Any]] = {} | ||
| # MoE runner backend as resolved during this daemon's model load; the | ||
| # client compares it once its own model is built. | ||
| self.moe_runner_backend: str = "" |
Author
There was a problem hiding this comment.
It was sent to the client side to ensure both sides load the weights using the same backend:
As different MoE backends post-process the weight tensor (e.g., permute, reorder) into different physical layout, mixing backends will lead to shape mismatch or numeric error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#27139 enables the daemon mode for model weight loading from CUDA IPC. This PR extends its supporting range further by including NVFP4 models (e.g.,
nvidia/Qwen3-30B-A3B-FP4).Modifications
The design of this PR delegates the post-process procedure of NVFP4 weight loading to daemon. The daemon process captures some of the important attributes like
weights_padding_colsandintermediate_size_per_partitionafter loading the raw weights, and handle over them to the client then. At the client side, it just rebinds them into the related quantized parameters after receiving the CUDA IPC handle.Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #30679818820
Latest PR Test (Extra): ❌ Run #30679818652