Skip to content

Fix connection issue #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryzing merged 6 commits into from
Mar 27, 2026
Merged

Fix connection issue #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6249f67
fix connection issue
yknl Mar 27, 2026
82ea85c
chore: bump minor version to 0.18.0
Copilot Mar 27, 2026
b1bc44e
Bump package.lock
aryzing Mar 27, 2026
ceca3b3
Fix version
aryzing Mar 27, 2026
11f0710
Add comment
aryzing Mar 27, 2026
83ffa2c
Fix typo
aryzing Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@sats-connect/core",
"version": "0.17.5",
"version": "0.17.6",
"main": "dist/index.mjs",
"module": "dist/index.mjs",
"types": "dist/index.d.mts",
Expand Down
11 changes: 10 additions & 1 deletion src/request/rpc/objects/namespaces/wallet/methods/requestPermissions/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@ import { walletMethods } from 'src/request/methods';
import * as v from 'valibot';
import { permissionRequestParamsSchema } from '../../shared/permissions';

export const walletRequestPermissionsParamsSchema = v.array(permissionRequestParamsSchema);
/**
* This method was previously used to connect to the wallet similarly to how
* `wallet_connect` is used now: when no permissions are explicitly requested,
* account read permissions are implied. The `nullish` schema allows maintaining
* backwards compatibility with this behavior while still allowing for explicit
* permission requests.
*/
export const walletRequestPermissionsParamsSchema = v.nullish(
v.array(permissionRequestParamsSchema)
);

export type WalletRequestPermissionsParams = v.InferOutput<
typeof walletRequestPermissionsParamsSchema
Expand Down
Loading