Skip to content

Fix connection issue - #124

Merged
aryzing merged 6 commits into
mainfrom
fix/connection-issue
Mar 27, 2026
Merged

Fix connection issue#124
aryzing merged 6 commits into
mainfrom
fix/connection-issue

Conversation

@yknl

@yknl yknl commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Package pre-release info

npm install @sats-connect/core@0.17.6-78e54e2 -E
bun install @sats-connect/core@0.17.6-78e54e2 -E

fix: make wallet_requestPermissions params optional

walletRequestPermissionsRequestSchema required params to be a non-optional Array, unlike wallet_connect/wallet_connectV2 which use v.nullish(). This caused the Xverse extension's rpcRequestSchema variant validation to reject wallet_requestPermissions calls without params, silently dropping the message and hanging the dApp indefinitely.

Wraps walletRequestPermissionsParamsSchema with v.nullish() to match the existing pattern. No consumer changes needed — the extension's handleRequestPermissions already handles !params by delegating to the wallet_connect flow.

chore: bump minor version to 0.18.0

Bumps the package version from 0.17.5 to 0.18.0 to reflect the fix as a minor release.


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@yknl
yknl requested a review from aryzing March 27, 2026 06:09
@aryzing

aryzing commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@copilot add a minor version bump to package.json

Copilot AI commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@copilot add a minor version bump to package.json

Done — bumped to 0.18.0 in commit 82ea85c.

aryzing
aryzing previously approved these changes Mar 27, 2026
terencehh
terencehh previously approved these changes Mar 27, 2026
@aryzing
aryzing dismissed stale reviews from terencehh and themself via 520fa68 March 27, 2026 08:33
@aryzing
aryzing force-pushed the fix/connection-issue branch from 520fa68 to 11f0710 Compare March 27, 2026 08:58
Comment thread src/request/rpc/objects/namespaces/wallet/methods/requestPermissions/request.ts Outdated
@aryzing
aryzing merged commit d4ac96b into main Mar 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants