Skip to content

fix(snaptemplates): bugfix for recs variants config settings #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisFrazier77 wants to merge 1 commit into from
Closed

fix(snaptemplates): bugfix for recs variants config settings #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/snap-preact/src/Templates/SnapTemplates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,9 @@ export function createSnapConfig(templateConfig: SnapTemplatesConfig, templatesS
components: createRecommendationComponentMapping(templateConfig, templatesStore),
config: {
plugins: createPlugins(templateConfig, templatesStore, 'recommendation'),
settings: {
variants: templateConfig.recommendation?.settings?.variants,
},
...templateConfig.recommendation?.settings!,
Comment on lines +491 to 493
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit variants assignment (lines 490-492) is immediately overwritten by the spread of templateConfig.recommendation?.settings! on line 493. This makes the explicit assignment redundant and ineffective. If the intention is to ensure variants is included, remove the explicit assignment since the spread already includes it. If the intention is to set a default or transform the value, move the spread before the explicit assignment.

Suggested change
variants: templateConfig.recommendation?.settings?.variants,
},
...templateConfig.recommendation?.settings!,
...templateConfig.recommendation?.settings!,
variants: templateConfig.recommendation?.settings?.variants,
},

Copilot uses AI. Check for mistakes.
},
};
Expand Down
Loading