Skip to content

Comments

fix(snaptemplates): bugfix for recs variants config settings#140

Closed
chrisFrazier77 wants to merge 1 commit intodevelopfrom
templates-recs-variants
Closed

fix(snaptemplates): bugfix for recs variants config settings#140
chrisFrazier77 wants to merge 1 commit intodevelopfrom
templates-recs-variants

Conversation

@chrisFrazier77
Copy link

No description provided.

Copilot AI review requested due to automatic review settings October 29, 2025 21:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to explicitly pass the variants configuration from the recommendation template config to the recommendation instantiator config. The change adds a nested settings object with the variants property before spreading all recommendation settings.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +491 to 493
variants: templateConfig.recommendation?.settings?.variants,
},
...templateConfig.recommendation?.settings!,
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit variants assignment (lines 490-492) is immediately overwritten by the spread of templateConfig.recommendation?.settings! on line 493. This makes the explicit assignment redundant and ineffective. If the intention is to ensure variants is included, remove the explicit assignment since the spread already includes it. If the intention is to set a default or transform the value, move the spread before the explicit assignment.

Suggested change
variants: templateConfig.recommendation?.settings?.variants,
},
...templateConfig.recommendation?.settings!,
...templateConfig.recommendation?.settings!,
variants: templateConfig.recommendation?.settings?.variants,
},

Copilot uses AI. Check for mistakes.
@chrisFrazier77
Copy link
Author

work was done in variants_refactor branch

@chrisFrazier77 chrisFrazier77 deleted the templates-recs-variants branch January 14, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant