fix(snaptemplates): bugfix for recs variants config settings#140
fix(snaptemplates): bugfix for recs variants config settings#140chrisFrazier77 wants to merge 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to explicitly pass the variants configuration from the recommendation template config to the recommendation instantiator config. The change adds a nested settings object with the variants property before spreading all recommendation settings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| variants: templateConfig.recommendation?.settings?.variants, | ||
| }, | ||
| ...templateConfig.recommendation?.settings!, |
There was a problem hiding this comment.
The explicit variants assignment (lines 490-492) is immediately overwritten by the spread of templateConfig.recommendation?.settings! on line 493. This makes the explicit assignment redundant and ineffective. If the intention is to ensure variants is included, remove the explicit assignment since the spread already includes it. If the intention is to set a default or transform the value, move the spread before the explicit assignment.
| variants: templateConfig.recommendation?.settings?.variants, | |
| }, | |
| ...templateConfig.recommendation?.settings!, | |
| ...templateConfig.recommendation?.settings!, | |
| variants: templateConfig.recommendation?.settings?.variants, | |
| }, |
|
work was done in variants_refactor branch |
No description provided.