Handle failed build-report downloads gracefully

R/biocBuildReportDB.R

@@ -31,6 +31,8 @@ biocBuildReportDB <- function(
     urls <- .get_build_report_tgz_url(version, pkgType)
     names(urls) <- pkgType
     urls <- Filter(.url_exists, urls)
+    if (!length(urls))
+        stop("Bioconductor build report could not be reached", call. = FALSE)
 
     tempfolders <- replicate(length(urls), tempfile())
 

R/biocBuildStatusDB.R

@@ -41,6 +41,8 @@ biocBuildStatusDB <- function(
     urls <- get_build_status_db_url(version, pkgType)
     names(urls) <- pkgType
     urls <- Filter(.url_exists, urls)
+    if (!length(urls))
+        stop("Bioconductor build report could not be reached", call. = FALSE)
 
     url_list <- lapply(
         urls,

R/utilities.R

@@ -116,8 +116,12 @@ get_deprecated_status_df <- function(version) {
     if (
         identical(nrow(bquery), 1L) && (is.na(needsUpdate) || needsUpdate)
     )
-        bfcdownload(
-            x = bfc, rid = bquery[["rid"]], ask = FALSE
+        tryCatch(
+            bfcdownload(x = bfc, rid = bquery[["rid"]], ask = FALSE),
+            error = function(e) warning(
+                "could not refresh ", url, "; using cached copy: ",
+                conditionMessage(e), call. = FALSE
+            )
         )
 
     bfcrpath(

tests/testthat/helper-network.R

@@ -17,6 +17,7 @@
 #' Bioconductor-hosted resources specifically (general internet access does
 #' not guarantee bioconductor.org is up).
 skip_if_bioc_offline <- function() {
+    testthat::skip_on_cran()
     testthat::skip_if_not(
         .bioc_reachable(), "bioconductor.org is not reachable"
     )

tests/testthat/test_biocBuildStatusDB.R

@@ -46,3 +46,8 @@ test_that("biocBuildStatusDB errors on an invalid pkgType", {
         "'arg' should be one of"
     )
 })
+
+test_that("biocBuildStatusDB errors clearly when no build report URL is reachable", {
+    testthat::local_mocked_bindings(.url_exists = function(url) FALSE)
+    expect_error(biocBuildStatusDB("devel"), "could not be reached")
+})