Repository navigation
Handle failed build-report downloads gracefully - #91
Merged
Merged
Conversation
- .cache_url_file(): if refreshing a stale cached file fails, warn and fall back to the cached copy instead of erroring. - biocBuildStatusDB()/biocBuildReportDB(): stop with a clear message when no build report URL is reachable, instead of the cryptic "second argument must be a list" from do.call(rbind, ...). - skip_if_bioc_offline() now also calls skip_on_cran(). - Add a mocked test for the unreachable case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the windows-latest (release) failure in
test_problemPage.R: a live build-report download failed (download failed), and thenbiocBuildStatusDB()hitdo.call(rbind, ...): "second argument must be a list" once every URL had been filtered out as unreachable..cache_url_file(): if refreshing a stale cached file fails, it now warns and uses the cached copy.biocBuildStatusDB()/biocBuildReportDB(): when no URL is reachable they now stop with "Bioconductor build report could not be reached".skip_if_bioc_offline()now also callsskip_on_cran(). CI still runs these tests becausecheck-r-packagesetsNOT_CRAN=true.Local run:
test_biocBuildStatusDB.Randtest_problemPage.Rpassed (0 failures).🤖 Generated with Claude Code