ping: allow pinging svc addresses#4898
Open
uniquefine wants to merge 2 commits into
Open
Conversation
tzaeschke
reviewed
Mar 6, 2026
| Use 'scion address' on the remote SCION host to determine the ISD-AS and pingable IP address. | ||
|
|
||
| You can also ping SCION control plane services in the remote AS by using the SVC address of the | ||
| service, e.g., '1-ff00:0:110,CS' to ping the control service. |
Contributor
There was a problem hiding this comment.
Suggested change
| service, e.g., '1-ff00:0:110,CS' to ping the control service. | |
| service, e.g., '1-ff00:0:110,CS' to ping a control service. |
I guess it randomly picks one?
Contributor
Author
There was a problem hiding this comment.
Yes, it picks the first one.
dbc17bc to
eebd4e7
Compare
eebd4e7 to
5a5e4c2
Compare
5a5e4c2 to
cb58105
Compare
4b4184e to
a575785
Compare
| // provided service type (addr.SvcCS or addr.SvcDS). If no discovery information | ||
| // is available, it will return a SVC address with the destination IA and the | ||
| // path's underlay next hop. | ||
| // The caller must ensure that the path is not nil. |
Collaborator
There was a problem hiding this comment.
This documentation string doesn't match the behavior...
Collaborator
There was a problem hiding this comment.
it seems to be a plain copy of the function doc above.
33caf85 to
aa74736
Compare
aa74736 to
d970bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the
scion pingtool to allow pinging SCION control plane services by svc address.This is useful if you want to ping some host in a remote ISD-AS but don't know a specific IP.