-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump the actions group across 1 directory with 2 updates #307
chore(deps): bump the actions group across 1 directory with 2 updates #307
Conversation
@dependabot rebase |
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
Bumps the actions group with 2 updates in the / directory: [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) and [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request). Updates `pypa/cibuildwheel` from 2.17 to 2.20 - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.17...v2.20) Updates `amannn/action-semantic-pull-request` from 5.5.2 to 5.5.3 - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@v5.5.2...v5.5.3) --- updated-dependencies: - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>
9ddb91c
to
42b5ae5
Compare
I believe from pypa/cibuildwheel#1926 (comment) and thaler-lab/Wasserstein#28 (thanks @henryiii) that this means that fastjet/.github/workflows/ci.yml Line 51 in f90dc72
and fastjet/.github/workflows/wheels.yml Line 65 in f90dc72
need to have |
Though something like - name: Build gmp from source for macOS cibuildwheel
if: runner.os == 'macOS'
env:
MACOSX_DEPLOYMENT_TARGET: "10.9"
run: |
curl -LO https://gmplib.org/download/gmp/gmp-6.3.0.tar.xz
tar -xf gmp-6.3.0.tar.xz
cd gmp-6.3.0
./configure --prefix=$(brew --prefix)
make --jobs
make install
cd ..
rm -rf gmp-6.3.0 gmp-6.3.0.tar.xz seems to be timing out on the
which I assume means that |
* For macos-13 the MACOSX_DEPLOYMENT_TARGET for homebrew installed gmp on x86 macOS is different from the version expected by cibuildwheel v2.20. This requires building gmp form source under the MACOSX_DEPLOYMENT_TARGET 10.9 to ensure compatability during the wheel build.
- name: Clone gmp | ||
if: runner.os == 'macOS' | ||
uses: actions/checkout@v4 | ||
with: | ||
repository: gmp-mirror/gmp-6.3 | ||
path: gmp-6.3 | ||
|
||
- name: Build gmp from source for MACOSX_DEPLOYMENT_TARGET | ||
if: runner.os == 'macOS' | ||
env: | ||
MACOSX_DEPLOYMENT_TARGET: "10.9" | ||
working-directory: gmp-6.3 | ||
run: | | ||
brew install texinfo | ||
autoreconf -i -f | ||
./configure --help | ||
./configure \ | ||
--prefix=$(brew --prefix) \ | ||
--enable-cxx | ||
touch ./doc/version.texi | ||
make --jobs | ||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henryiii tagging you for review to see if you know of a more intelligent/faster way to build gmp
for source to avoid MACOSX_DEPLOYMENT_TARGET
mismatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more or less what you need to do. If you use CMake for the parent build, you can make it an option to have it do this for you as a sub build, but otherwise, it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this @matthewfeickert! LGTM, but I guess we should wait a bit before merging in case Henry has any suggestions?
@rkansal47 I think we can wait until the end of the day today and then merge if there's no further feedback. If Henry has additional comments later we can always make a fix PR. |
Bumps the actions group with 2 updates in the / directory: pypa/cibuildwheel and amannn/action-semantic-pull-request.
Updates
pypa/cibuildwheel
from 2.17 to 2.20Release notes
Sourced from pypa/cibuildwheel's releases.
... (truncated)
Changelog
Sourced from pypa/cibuildwheel's changelog.
... (truncated)
Commits
bd033a4
Bump version: v2.20.09d023cf
Build CPython 3.13 by default (#1950)8a69dbd
[Bot] Update dependencies (#1949)147de6f
[pre-commit.ci] pre-commit autoupdate (#1947)e217e44
[Bot] Update dependencies (#1946)871ef6b
tests: show xfail traceback summaries again (#1943)fac72f0
[pre-commit.ci] pre-commit autoupdate (#1944)d4c3321
feat: addCIBW_ALLOW_EMPTY
environment variable (#1937)5af5df4
[Bot] Update dependencies (#1935)6c5cf87
docs: fix nox docs command (#1938)Updates
amannn/action-semantic-pull-request
from 5.5.2 to 5.5.3Release notes
Sourced from amannn/action-semantic-pull-request's releases.
Changelog
Sourced from amannn/action-semantic-pull-request's changelog.
Commits
0723387
chore: Release 5.5.3 [skip ci]2d952a1
fix: Bumpbraces
dependency (#269. by@EelcoLos
)a663946
chore(deps): Bump braces from 3.0.2 to 3.0.3 (#269 by@EelcoLos
)e32d7e6
chore: Update major tag (#268 by@gustavkj
)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions