-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump the actions group across 1 directory with 2 updates #307
Merged
matthewfeickert
merged 2 commits into
main
from
dependabot/github_actions/actions-353da4b8ba
Sep 12, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,10 +86,33 @@ jobs: | |
| - name: Install compiler tools on macOS | ||
| if: runner.os == 'macOS' | ||
| run: | | ||
| brew install make automake swig gmp mpfr boost | ||
| brew install make automake swig mpfr boost | ||
| export PATH="/usr/local/opt/make/libexec/gnubin:$PATH" | ||
|
|
||
| - uses: pypa/[email protected] | ||
| - name: Clone gmp | ||
| if: runner.os == 'macOS' | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: gmp-mirror/gmp-6.3 | ||
| path: gmp-6.3 | ||
|
|
||
| - name: Build gmp from source for MACOSX_DEPLOYMENT_TARGET | ||
| if: runner.os == 'macOS' | ||
| env: | ||
| MACOSX_DEPLOYMENT_TARGET: "10.9" | ||
| working-directory: gmp-6.3 | ||
| run: | | ||
| brew install texinfo | ||
| autoreconf -i -f | ||
| ./configure --help | ||
| ./configure \ | ||
| --prefix=$(brew --prefix) \ | ||
| --enable-cxx | ||
| touch ./doc/version.texi | ||
| make --jobs | ||
| make install | ||
|
|
||
| - uses: pypa/[email protected] | ||
| env: | ||
| CIBW_ARCHS: ${{ matrix.arch }} | ||
| CIBW_BUILD: cp${{ matrix.python }}-* | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,6 @@ jobs: | |
| name: Validate PR title | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/[email protected].2 | ||
| - uses: amannn/[email protected].3 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,10 +62,33 @@ jobs: | |
| - name: Install compiler tools on macOS | ||
| if: runner.os == 'macOS' | ||
| run: | | ||
| brew install make automake swig gmp mpfr boost | ||
| brew install make automake swig mpfr boost | ||
| export PATH="/usr/local/opt/make/libexec/gnubin:$PATH" | ||
| - uses: pypa/[email protected] | ||
| - name: Clone gmp | ||
| if: runner.os == 'macOS' | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: gmp-mirror/gmp-6.3 | ||
| path: gmp-6.3 | ||
|
|
||
| - name: Build gmp from source for MACOSX_DEPLOYMENT_TARGET | ||
| if: runner.os == 'macOS' | ||
| env: | ||
| MACOSX_DEPLOYMENT_TARGET: "10.9" | ||
| working-directory: gmp-6.3 | ||
| run: | | ||
| brew install texinfo | ||
| autoreconf -i -f | ||
| ./configure --help | ||
| ./configure \ | ||
| --prefix=$(brew --prefix) \ | ||
| --enable-cxx | ||
| touch ./doc/version.texi | ||
| make --jobs | ||
| make install | ||
| - uses: pypa/[email protected] | ||
| env: | ||
| CIBW_ARCHS: ${{ matrix.arch }} | ||
| CIBW_BUILD: cp${{ matrix.python }}-* | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henryiii tagging you for review to see if you know of a more intelligent/faster way to build
gmpfor source to avoidMACOSX_DEPLOYMENT_TARGETmismatch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more or less what you need to do. If you use CMake for the parent build, you can make it an option to have it do this for you as a sub build, but otherwise, it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @henryiii. Okay, so seems like another thing that would benefit from Issue #310 in the future.