-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build issues #213
Fix build issues #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes lgtm. +1 for merging if the tests pass
@fchapoton @dimpase could you please have a look and merge this (and perhaps directly cut a new release). I'm very sorry for having introduced this bug during the meson migration. |
I don't understand why this PR touches meson.build files. IMHO removing
there might create meson build problems. |
OK, good then |
Thanks for merging this 😄. |
hopefully later today |
@dimpase I see you published the new release on GitHub, but you didn't update version number in pyproject.toml? (might break pypi) |
oops. OK, I'll do another one, also including one more just merged PR, by you. Build systems ought to get the version from the git tag... |
The migration to the meson build system, causes failures when building packages that depend on
cysignals
but don't use meson (i.e. they usesetup.py
).Closes: #212