Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #213

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix build issues #213

merged 1 commit into from
Dec 17, 2024

Conversation

ludopulles
Copy link
Contributor

The migration to the meson build system, causes failures when building packages that depend on cysignals but don't use meson (i.e. they use setup.py).

Closes: #212

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Changes lgtm. +1 for merging if the tests pass

@tobiasdiez
Copy link
Contributor

@fchapoton @dimpase could you please have a look and merge this (and perhaps directly cut a new release).

I'm very sorry for having introduced this bug during the meson migration.

@dimpase
Copy link
Member

dimpase commented Dec 16, 2024

I don't understand why this PR touches meson.build files. IMHO removing

add_project_arguments(
  '-X preliminary_late_includes_cy28=True',
  language: 'cython',

there might create meson build problems.
This is because meson builds don't understand these #... directives in Cython files, right, @tobiasdiez ?

example/meson.build Show resolved Hide resolved
@dimpase dimpase merged commit cdbf764 into sagemath:main Dec 17, 2024
24 checks passed
@dimpase
Copy link
Member

dimpase commented Dec 17, 2024

OK, good then

@ludopulles
Copy link
Contributor Author

Thanks for merging this 😄.
Is there also a new release planned in the near future?

@dimpase
Copy link
Member

dimpase commented Dec 17, 2024

hopefully later today

@user202729
Copy link
Contributor

user202729 commented Dec 19, 2024

@dimpase I see you published the new release on GitHub, but you didn't update version number in pyproject.toml? (might break pypi)

@dimpase
Copy link
Member

dimpase commented Dec 19, 2024

oops. OK, I'll do another one, also including one more just merged PR, by you.

Build systems ought to get the version from the git tag...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumers failing to build with v1.12.0
4 participants