Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer tools to conda environment #39141

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

Add a few dependencies needed for some developer tooling and/or linting.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Add a few dependencies needed for some developer tooling and/or linting.
Copy link

Documentation preview for this PR (built with commit 56fe3d0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

Not sure if this is desirable, sometimes some user just want to build from source without doing development work.

@tobiasdiez
Copy link
Contributor Author

Not sure if this is desirable, sometimes some user just want to build from source without doing development work.

We had a separate -dev environment in the past, but it generated quite a bit of maintenance overhead.

In which scenarios do you think someone would like to build sage from source using conda for dependencies, but not actually work on sage? (In particular, why would she not just install the distributed sage-on-conda?) In this case, would it be so inconvenient to also install a couple of dev tools?

@user202729
Copy link
Contributor

I see. They're just some theoretical considerations.

@tobiasdiez
Copy link
Contributor Author

I see. They're just some theoretical considerations.

Thanks a lot for bringing them up!

--

The tests fail because of sagemath/cysignals#212, which is fixed in sagemath/cysignals#213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants