Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/assets/v1.3.0/compatibility_fallback_handler.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we tend to slightly favor the EIP-155 deployments (i.e. using the Safe singleton factory) over the legacy "canonical" deployments.

Is there a reason you want to prefer the legacy deployment over the EIP-155 one? If not, I would suggest re-ordering these to be:

Suggested change
"5064014": ["canonical", "eip155"],
"5064014": ["eip155", "canonical"],

"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/create_call.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/gnosis_safe.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/gnosis_safe_l2.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/multi_send.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/multi_send_call_only.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/proxy_factory.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/sign_message_lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down
1 change: 1 addition & 0 deletions src/assets/v1.3.0/simulate_tx_accessor.json
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@
"810180": "zksync",
"978657": "canonical",
"4457845": "zksync",
"5064014": ["canonical", "eip155"],
"6038361": ["eip155", "canonical"],
"6985385": "eip155",
"7225878": "eip155",
Expand Down