Ethereal Mainnet 1.3.0 #1265
Open
Ethereal Mainnet 1.3.0 #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpochta
force-pushed
the
feat/ethereal-mainnet-1.3.0
branch
from
4c73b0c to
d9f2900
Compare
nlordell
approved these changes
Oct 6, 2025
nlordell
reviewed
Oct 6, 2025
| "810180": "zksync", | ||
| "978657": "canonical", | ||
| "4457845": "zksync", | ||
| "5064014": ["canonical", "eip155"], |
There was a problem hiding this comment.
In general, we tend to slightly favor the EIP-155 deployments (i.e. using the Safe singleton factory) over the legacy "canonical" deployments.
Is there a reason you want to prefer the legacy deployment over the EIP-155 one? If not, I would suggest re-ordering these to be:
Suggested change
| "5064014": ["canonical", "eip155"], | |
| "5064014": ["eip155", "canonical"], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill the following form:
Provide the Chain ID (Only 1 chain id per PR).
Relevant information:
https://chainlist.org/?search=ethereal