feat: Rust recipe runner integration with engine selection by rysweet · Pull Request #2951 · rysweet/amplihack

rysweet · 2026-03-08T03:08:40Z

Rust Recipe Runner Integration

Integrates the standalone Rust recipe runner into amplihack with automatic engine selection and startup dependency management.

What's included

src/amplihack/recipes/rust_runner.py — Binary wrapper with find_rust_binary(), ensure_rust_recipe_runner(), and run_recipe_via_rust(). Raises RustRunnerNotFoundError when the Rust engine is explicitly selected but the binary is missing (no silent fallback).
src/amplihack/recipes/__init__.py — Engine selection via RECIPE_RUNNER_ENGINE env var:
- rust → Rust binary only (fails if not installed)
- python → Python runner only
- (not set) → auto-detect (Rust if binary found, Python otherwise)
src/amplihack/install.py — Step 6.5 automatically installs recipe-runner-rs during amplihack install if cargo is available
tests/recipes/test_rust_runner.py — 26 tests covering binary discovery, execution, JSON parsing, engine selection, and the ensure flow
docs/recipes/README.md — Documents engine selection table and auto-install
.gitignore — Excludes recipe runner checkout directory

Design Principles

No fallback — when RECIPE_RUNNER_ENGINE=rust, the binary must exist or execution fails with a clear error
Auto-detect is a convenience — if neither env var is set, the system picks the best available engine and logs which one was selected
Best-effort install — ensure_rust_recipe_runner() tries cargo install --git but doesn't block startup if it fails

Testing

uv run pytest tests/recipes/test_rust_runner.py -v  # 26 tests

github-actions · 2026-03-08T03:09:09Z

🤖 Auto-fixed version bump

The version in pyproject.toml has been automatically bumped to the next patch version.

If you need a minor or major version bump instead, please update pyproject.toml manually and push the change.

github-actions · 2026-03-08T03:12:28Z

Repo Guardian - Passed

✅ All files are durable repository content

Reviewed 6 changed files:

.gitignore - Repository configuration
docs/recipes/README.md - Feature documentation
pyproject.toml - Version metadata
src/amplihack/recipes/__init__.py - Engine selection logic
src/amplihack/recipes/rust_runner.py - Rust integration module
tests/recipes/test_rust_runner.py - Unit tests

No ephemeral content detected (no meeting notes, temporary scripts, or point-in-time documents).

AI generated by Repo Guardian

github-actions · 2026-03-08T03:45:16Z

🤖 Auto-fixed version bump

The version in pyproject.toml has been automatically bumped to the next patch version.

If you need a minor or major version bump instead, please update pyproject.toml manually and push the change.

github-actions · 2026-03-08T03:46:25Z

🤖 Auto-fixed version bump

The version in pyproject.toml has been automatically bumped to the next patch version.

If you need a minor or major version bump instead, please update pyproject.toml manually and push the change.

github-actions · 2026-03-08T13:00:48Z

🤖 PR Triage Complete

Risk Level: Medium-High (6.5/10)
Priority: Medium
Status: ⚠️ Requires attention before merge

📊 Summary

This PR integrates a Rust recipe runner as an alternative execution engine with automatic selection and graceful fallback to Python.

Changes:

626 additions, 4 deletions across 7 files
New rust_runner.py module with binary discovery and execution
Engine selection via RECIPE_RUNNER_ENGINE environment variable
Auto-install during amplihack install when cargo available
26 comprehensive tests

⚠️ Critical Issues

Merge Conflicts - mergeable_state: dirty - must be resolved before merging
Cross-platform validation needed - Binary discovery may behave differently on Windows/macOS/Linux
CI/CD impact - Rust toolchain availability in CI environments not validated

🎯 Strengths

✅ Excellent test coverage (26 tests)
✅ Clear error handling (no silent fallback when RECIPE_RUNNER_ENGINE=rust)
✅ Backwards compatible (defaults to Python)
✅ Well-documented engine selection
✅ Graceful degradation pattern

🔍 Concerns

External dependency - Adds Rust toolchain requirement (optional but increases complexity)
Installation time - Auto-install may slow amplihack install process
Attack surface - New binary dependency requires security review
Platform coverage - Cross-platform binary discovery needs validation

📋 Recommended Actions

Before Merge:

✅ CRITICAL: Resolve merge conflicts
✅ Test on Windows, macOS, Linux to validate binary discovery
✅ Verify CI behavior when Rust unavailable
✅ Validate install.py handles cargo failures gracefully
⚙️ Consider performance benchmarks (Rust vs Python engine)

Post-Merge:

Monitor installation metrics for slowdowns
Collect engine selection telemetry to understand adoption
Document recommended environments for Rust engine

🏷️ Labels Applied

triage:complete
triage:needs-testing
triage:medium-risk

Triaged by PR Triage Agent on 2026-03-08T12:57:00Z

AI generated by PR Triage Agent

PR-M1: Split run_recipe_via_rust into focused helpers PR-M2: Configurable timeouts via env vars PR-M3: Remove point-in-time Python references in docs PR-M4: Remove hardcoded counts from docs PR-M5: Add tests for empty results and exception paths PR-L1: Redact context values in log output PR-L2: Lazy binary search path evaluation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-08T18:44:21Z

🟡 Triage Result: NEEDS CONFLICT RESOLUTION

Priority: MEDIUM-HIGH | Risk: HIGH

Assessment

High-value Rust recipe runner integration with manageable scope, but merge conflicts prevent automated merging.

Stats:

9 files changed (+883/-13)
6 commits, 15.5 hours old
Recent activity shows active development

Blockers

❌ Merge conflicts - must be resolved before review

Recommended Action

Resolve merge conflicts via rebase:

git checkout feature/rust-recipe-runner-integration
git fetch origin
git rebase origin/main
# Resolve conflicts
git push --force-with-lease

Manual review after conflicts resolved due to integration complexity

Why This Matters

Recipe runner integration is foundational infrastructure. Clean merge critical for:

Engine selection logic correctness
Startup dependency management
Python/Rust compatibility

Related Issues

See triage issue tracking merge conflict epidemic
Part of 75% PR conflict rate (3 of 4 PRs)

Automated triage by PR Triage Agent - Run #22827330377

AI generated by PR Triage Agent

Adds the Rust recipe runner binary integration with automatic engine selection and startup dependency management. - src/amplihack/recipes/rust_runner.py: Binary wrapper with find, ensure, and execute functions. RustRunnerNotFoundError for explicit failures. ensure_rust_recipe_runner() auto-installs via cargo if binary is missing. - src/amplihack/recipes/__init__.py: Engine selection via RECIPE_RUNNER_ENGINE env var (rust/python/auto-detect). Exports ensure_rust_recipe_runner. - src/amplihack/install.py: Step 6.5 ensures binary during amplihack install. - tests/recipes/test_rust_runner.py: 26 tests covering discovery, execution, engine selection, and ensure flow. - docs/recipes/README.md: Documents engine selection and auto-install. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Validate RECIPE_RUNNER_ENGINE values (raise ValueError on unknown) - Add non-interactive footer to NestedSessionAdapter - Add session depth tracking to NestedSessionAdapter Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

PR-M1: Split run_recipe_via_rust into focused helpers PR-M2: Configurable timeouts via env vars PR-M3: Remove point-in-time Python references in docs PR-M4: Remove hardcoded counts from docs PR-M5: Add tests for empty results and exception paths PR-L1: Redact context values in log output PR-L2: Lazy binary search path evaluation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…th (C2-PR-1, C2-PR-2, C2-PR-6, C2-PR-9, C2-PR-10) C2-PR-1: Raise ValueError on invalid RECIPE_RUNNER_ENGINE values C2-PR-2: Log full traceback for ensure_rust_recipe_runner failures C2-PR-6: Enforce AMPLIHACK_MAX_DEPTH in execute_agent_step C2-PR-9: Add test for invalid engine value validation C2-PR-10: Add test for execution timeout propagation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…g_dir (C2-INT-3/4/5/6/7/10) C2-INT-3: Serialize Duration as f64 seconds (Rust repo) C2-INT-4/5/6: Document Rust-only features in engine comparison table C2-INT-7: Document all environment variables C2-INT-10: Resolve working_dir to absolute path to prevent double-application Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ority test (C3-PR-1/2/3) C3-PR-1: Print warning on install exception (was silent) C3-PR-2: Return resolved path from find_rust_binary for env var path C3-PR-3: Fix false-confidence test with discriminating mock Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-08T20:50:11Z

🤖 Auto-fixed version bump

The version in pyproject.toml has been automatically bumped to the next patch version.

If you need a minor or major version bump instead, please update pyproject.toml manually and push the change.

github-actions · 2026-03-08T20:54:00Z

Repo Guardian - Passed

✅ All files are durable repository content

Reviewed 8 changed files:

.gitignore - Repository configuration
docs/recipes/README.md - Feature documentation
pyproject.toml - Version metadata
src/amplihack/install.py - Installation logic
src/amplihack/recipes/__init__.py - Engine selection logic
src/amplihack/recipes/adapters/nested_session.py - Adapter module
src/amplihack/recipes/rust_runner.py - Rust integration module
tests/recipes/test_rust_runner.py - Unit tests

No ephemeral content detected (no meeting notes, temporary scripts, or point-in-time documents).

AI generated by Repo Guardian

rysweet force-pushed the feature/rust-recipe-runner-integration branch from 1c447a3 to 902cfa8 Compare March 8, 2026 03:44

rysweet force-pushed the feature/rust-recipe-runner-integration branch from c5dd179 to c0d3e13 Compare March 8, 2026 03:45

github-actions bot mentioned this pull request Mar 8, 2026

[PR Triage Report] PR Triage Report - 5 Open PRs Analyzed (2026-03-08) #2955

Closed

github-actions bot added triage:complete triage:medium-risk triage:needs-testing labels Mar 8, 2026

github-actions bot mentioned this pull request Mar 8, 2026

[PR Triage Report] 75% of agent PRs have merge conflicts - blocking automated merging #2956

Closed

Ubuntu and others added 6 commits March 8, 2026 20:46

rysweet force-pushed the feature/rust-recipe-runner-integration branch from 33e5b79 to 16928c8 Compare March 8, 2026 20:49

[skip ci] chore: Auto-bump patch version

41bd8de

rysweet merged commit 63409a0 into main Mar 8, 2026
1 check passed

rysweet mentioned this pull request Mar 8, 2026

fix: ensure Rust recipe runner on startup, add cargo to prerequisites #2957

Merged

github-actions bot mentioned this pull request Mar 9, 2026

[PR Triage Report] Agent PR Triage Report — 2026-03-09 — 3 PRs (ALL EXTREME RISK) #2964

Open

rysweet mentioned this pull request Mar 9, 2026

amplihack-rs: Rust core runtime for deterministic infrastructure #2961

Open

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Rust recipe runner integration with engine selection#2951

feat: Rust recipe runner integration with engine selection#2951
rysweet merged 7 commits intomainfrom
feature/rust-recipe-runner-integration

rysweet commented Mar 8, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

rysweet commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rust Recipe Runner Integration

What's included

Design Principles

Testing

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Repo Guardian - Passed

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

github-actions bot commented Mar 8, 2026

🤖 PR Triage Complete

📊 Summary

⚠️ Critical Issues

🎯 Strengths

🔍 Concerns

📋 Recommended Actions

🏷️ Labels Applied

Uh oh!

github-actions bot commented Mar 8, 2026

🟡 Triage Result: NEEDS CONFLICT RESOLUTION

Assessment

Blockers

Recommended Action

Why This Matters

Related Issues

Uh oh!

github-actions bot commented Mar 8, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 8, 2026

Repo Guardian - Passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rysweet commented Mar 8, 2026 •

edited

Loading