Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Certificate cloneable (derive Clone) #319

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Make Certificate cloneable (derive Clone) #319

merged 1 commit into from
Mar 1, 2025

Conversation

MadLittleMods
Copy link
Contributor

Make Certificate cloneable (derive Clone)

Part of #17

CertificateParms is clone now. Certificate is not, but I think we'd accept a PR to make it so.

-- #17 (comment)

In a similar vein for deriving Debug for Certificate in 362e78a

cpu
cpu approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@cpu cpu added this pull request to the merge queue Mar 1, 2025
@cpu
Copy link
Member

cpu commented Mar 1, 2025

cpu added this pull request to the merge queue now

Feels small enough to merge w/o blocking on a third review.

Merged via the queue into rustls:main with commit dd0e101 Mar 1, 2025
15 checks passed
@cpu cpu mentioned this pull request Mar 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MadLittleMods @cpu @djc