Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KeyPair, CertificateParams and Certificate Cloneable #17

Open
nthuemmel opened this issue Jun 19, 2019 · 3 comments
Open

Make KeyPair, CertificateParams and Certificate Cloneable #17

nthuemmel opened this issue Jun 19, 2019 · 3 comments

Comments

@nthuemmel
Copy link
Contributor

Being able to clone() KeyPair, CertificateParams and Certificate would help a great deal in some situations.
Right now the only solution seems to serialize and then deserialize again
@est31
Copy link
Member

est31 commented Jun 19, 2019

Yeah, we should probably implement all the relevant traits listed in the API guidelines

@est31
Copy link
Member

est31 commented Jun 24, 2019

This depends on ring: briansmith/ring#859

@est31 est31 mentioned this issue Jun 24, 2019
Closed
@cpu
Copy link
Member

cpu commented Mar 28, 2024

CertificateParms is clone now. Certificate is not, but I think we'd accept a PR to make it so. I don't think it's a good idea to make KeyPair clone.

MadLittleMods added a commit to MadLittleMods/fork-rcgen that referenced this issue Feb 28, 2025
@MadLittleMods
derive Clone for Certificate
fe3a5c9 
Part of rustls#17
@MadLittleMods MadLittleMods mentioned this issue Feb 28, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 1, 2025
@MadLittleMods @cpu
derive Clone for Certificate
dd0e101 
Part of #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpu @est31 @nthuemmel