Skip to content

Bump MSRV to 1.70 #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Bump MSRV to 1.70 #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
strategy:
fail-fast: false
matrix:
build: [stable, 1.63.0, beta, nightly, macos, windows]
build: [stable, 1.70.0, beta, nightly, macos, windows]
include:
- build: stable
os: ubuntu-latest
rust: stable
- build: 1.63.0
- build: 1.70.0
os: ubuntu-latest
rust: 1.63.0
rust: 1.70.0
- build: beta
os: ubuntu-latest
rust: beta
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ possible intended.
keywords = ["io", "socket", "network"]
categories = ["api-bindings", "network-programming"]
edition = "2021"
rust-version = "1.63"
rust-version = "1.70"
include = [
"Cargo.toml",
"LICENSE-APACHE",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ feature flag.

# Minimum Supported Rust Version (MSRV)

Socket2 uses 1.63.0 as MSRV.
Socket2 uses 1.70.0 as MSRV.

# License

Expand Down
4 changes: 2 additions & 2 deletions src/sys/unix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2828,9 +2828,9 @@ impl crate::Socket {
#[cfg(all(feature = "all", any(target_os = "linux", target_os = "android")))]
#[repr(transparent)]
pub struct SockFilter {
// For some reason Rust 1.63 thinks this field is unused, while it's clearly
// For some reason Rust 1.70 thinks this field is unused, while it's clearly
// used in `SockFilter::new`. This issue seems fixed in later Rust versions,
// but we still need to support 1.63, adding allow(dead_code) ignores the
// but we still need to support 1.70, adding allow(dead_code) ignores the
// issue.
#[allow(dead_code)]
filter: libc::sock_filter,
Expand Down