Skip to content

Bump MSRV to 1.70 #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Bump MSRV to 1.70 #597

merged 1 commit into from
Jul 4, 2025

Conversation

Thomasdezeeuw
Copy link
Collaborator

No description provided.

@Thomasdezeeuw
Copy link
Collaborator Author

Seems like the dead code issue was not fixed in 1.70, have to put the work around back in.

@Darksonn
Copy link
Collaborator

Darksonn commented Jul 4, 2025

I don't think the use in the constructor is enough. That's a write, but you never read the field anywhere.

@Thomasdezeeuw
Copy link
Collaborator Author

I don't think the use in the constructor is enough. That's a write, but you never read the field anywhere.

Ah, that makes sense. I guess using it as a raw pointer doesn't count as a read

@Thomasdezeeuw Thomasdezeeuw merged commit f219a00 into master Jul 4, 2025
47 checks passed
@Thomasdezeeuw Thomasdezeeuw deleted the msrv-1.70 branch July 4, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants