Skip to content

Conversation

@fneddy
Copy link
Contributor

@fneddy fneddy commented Oct 20, 2025

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output.

To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fneddy fneddy force-pushed the fix_big_endian_GVN_tests branch from c047932 to 0304584 Compare October 21, 2025 06:29
The tests fail on s390x and presumably other big-endian systems, due
to check of raw alloc values in the MIR output.

To fix the tests remove the raw bytes from the MIR output
(via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the
matching diffs.
@fneddy fneddy force-pushed the fix_big_endian_GVN_tests branch from 0304584 to cbae956 Compare October 21, 2025 06:30
@jieyouxu
Copy link
Member

jieyouxu commented Nov 1, 2025

r? mir-opt

@rustbot rustbot assigned saethlin and unassigned Mark-Simulacrum Nov 1, 2025
@saethlin
Copy link
Member

saethlin commented Nov 4, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

📌 Commit cbae956 has been approved by saethlin

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 4, 2025
…=saethlin

Fix tests for big-endian

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output.

To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 4, 2025
…=saethlin

Fix tests for big-endian

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output.

To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 4, 2025
…=saethlin

Fix tests for big-endian

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output.

To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.
bors added a commit that referenced this pull request Nov 4, 2025
Rollup of 5 pull requests

Successful merges:

 - #145314 (Tweak output of missing lifetime on associated type)
 - #147803 (Add -Zannotate-moves for profiler visibility of move/copy operations (codegen))
 - #147925 (Fix tests for big-endian)
 - #148341 (compiler: Fix a couple issues around cargo feature unification)
 - #148371 (Dogfood `trim_{suffix|prefix}` in compiler)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 5, 2025
Rollup of 6 pull requests

Successful merges:

 - #147355 (Add alignment parameter to `simd_masked_{load,store}`)
 - #147925 (Fix tests for big-endian)
 - #148341 (compiler: Fix a couple issues around cargo feature unification)
 - #148371 (Dogfood `trim_{suffix|prefix}` in compiler)
 - #148495 (Implement Path::is_empty)
 - #148502 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 5, 2025
Rollup of 6 pull requests

Successful merges:

 - #147355 (Add alignment parameter to `simd_masked_{load,store}`)
 - #147925 (Fix tests for big-endian)
 - #148341 (compiler: Fix a couple issues around cargo feature unification)
 - #148371 (Dogfood `trim_{suffix|prefix}` in compiler)
 - #148495 (Implement Path::is_empty)
 - #148502 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aa458ff into rust-lang:master Nov 5, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 5, 2025
rust-timer added a commit that referenced this pull request Nov 5, 2025
Rollup merge of #147925 - fneddy:fix_big_endian_GVN_tests, r=saethlin

Fix tests for big-endian

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output.

To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 6, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#147355 (Add alignment parameter to `simd_masked_{load,store}`)
 - rust-lang/rust#147925 (Fix tests for big-endian)
 - rust-lang/rust#148341 (compiler: Fix a couple issues around cargo feature unification)
 - rust-lang/rust#148371 (Dogfood `trim_{suffix|prefix}` in compiler)
 - rust-lang/rust#148495 (Implement Path::is_empty)
 - rust-lang/rust#148502 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Nov 8, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#147355 (Add alignment parameter to `simd_masked_{load,store}`)
 - rust-lang/rust#147925 (Fix tests for big-endian)
 - rust-lang/rust#148341 (compiler: Fix a couple issues around cargo feature unification)
 - rust-lang/rust#148371 (Dogfood `trim_{suffix|prefix}` in compiler)
 - rust-lang/rust#148495 (Implement Path::is_empty)
 - rust-lang/rust#148502 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants