Reword the issue comment to use denylist instead of blacklist #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's wrong with the word? The term doesn't seem to originate from anything to do with racism. |
|
While there may or may not be a racial component, I think at this point it's not a hard sell that using other terms is more inclusive and more descriptive. Nothing about the terms whitelist or blacklist tells you which one allows or denies unless you happen to know which colour means which. |
BenjaminBrienen
approved these changes
Nov 22, 2024
Mark-Simulacrum
approved these changes
Dec 8, 2024
Mark-Simulacrum
force-pushed
the
denylist
branch
from
23b6cef to
b723003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the comment left on github issues to read:
Which I think is more inclusive than the old message which referred to it as a blacklist. Conveniently, the config file in question doesn't use that term so I don't think it will be confusing to anyone trying to figure out how to drive it.
While making this change crater still uses blacklist a lot internally, but that seemed like kind of a lot for a driveby PR, but if you'd take the patch I'd be happy to switch it out.