Fix local webpack compilation #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sharvy , fyi. |
See https://mentalized.net/journal/2019/10/19/use-sass-modules-in-rails/ for details. Without this override, webpack compilation on local was failing with `Error: Node Sass does not yet support your current environment`. This workaround can be dropped when we upgrade to webpacker 6+.
solebared
force-pushed
the
switch-to-dart-sass
branch
from
7cbb351 to
0fef1f7
Compare
solebared
changed the title
|
@exbinary This looks great! +1 for I think you should create the issue Upgrade to Webpacker 6 and mention about this patch, so that whoever takes that issue, instantly knows about it. |
Good thinking! Tracked in #906 |
|
Merging this w/o full approval because AFAICT, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It appears that #897 broke webpack compilation locally (dev, test), at least on my machine, failing with:
Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (83)Some research led me to rails/webpacker#2716 which has been merged into webpacker 6 but not backported into our current version.
How
This changeset manually overrides the sass-loader implementation from
node-sasstosass, as described in this article.Next Steps
Left a FIXME comment in
config/webpack/environment.jsto remove this workaround when we upgrade to webpacker 6.Outstanding Questions, Concerns and Other Notes
?
Pre-Merge Checklist