Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 1.9 #7

Merged
merged 11 commits into from
Aug 1, 2021
Merged

Support Ruby 1.9 #7

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
da21797
Try building 1.9
mullermp Jul 26, 2021
80e7993
Use OpenSSL 1.0.2
mullermp Jul 26, 2021
0c385f2
Use a fork of ruby-builder that adds 1.9
mullermp Jul 26, 2021
0f07dc6
Build succeeds but try and fix bundler step
mullermp Jul 26, 2021
11118a9
Skip no-document for Ruby 1.9
mullermp Jul 26, 2021
080b4cc
Fix syntax.. oops
mullermp Jul 26, 2021
8fc246d
Fix JSON install with version
mullermp Jul 26, 2021
a2fa762
Revert changes so that PR can be made against main repo
mullermp Jul 26, 2021
52c066a
Merge pull request #1 from mullermp/ruby-19
mullermp Jul 26, 2021
45c2e0b
Update .github/workflows/build.yml
eregon Aug 1, 2021
41b4c94
Update .github/workflows/build.yml
eregon Aug 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# To workaround that, we use a branch of ruby-build which builds its own OpenSSL.
- name: Clone ruby-build
run: |
if [[ "${{ matrix.ruby }}" == ruby-2.[0123]* ]]; then
if [[ "${{ matrix.ruby }}" == ruby-2.[0123]* || "${{ matrix.ruby }}" == ruby-1.9* ]]; then
git clone --branch ruby23-openssl-linux https://github.com/eregon/ruby-build.git
else
git clone https://github.com/rbenv/ruby-build.git
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
# See https://bugs.ruby-lang.org/issues/17777 for 2.6.7
- name: Set warnflags for Ruby <= 2.2
run: echo "warnflags=-Wno-error=implicit-function-declaration" >> $GITHUB_ENV
if: startsWith(matrix.ruby, 'ruby-2.0') || startsWith(matrix.ruby, 'ruby-2.1') || startsWith(matrix.ruby, 'ruby-2.2') || matrix.ruby == 'ruby-2.6.7'
if: startsWith(matrix.ruby, 'ruby-1.9') || startsWith(matrix.ruby, 'ruby-2.0') || startsWith(matrix.ruby, 'ruby-2.1') || startsWith(matrix.ruby, 'ruby-2.2') || matrix.ruby == 'ruby-2.6.7'
- name: Build Ruby
run: ruby-build --verbose $RUBY_BUILD_RUBY_NAME $PREFIX
env:
Expand All @@ -81,13 +81,23 @@ jobs:
run: |
if [ ! -e $PREFIX/bin/bundle ]; then
export PATH="$PREFIX/bin:$PATH"
gem install bundler -v '~> 1' --no-document
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted, we can alternatively just remove --no-document and don't branch at all.

if [[ "${{ matrix.ruby }}" == ruby-1.9* ]]; then
gem install bundler -v '~> 1' --no-ri --no-rdoc
else
gem install bundler -v '~> 1' --no-document
fi
fi

- run: echo "$PREFIX/bin" >> $GITHUB_PATH
- run: ruby --version
- run: ruby -ropen-uri -e 'puts URI.send(:open, %{https://rubygems.org/}) { |f| f.read(1024) }'
- run: gem install json:2.2.0 --no-document
- name: Install JSON gem
run: |
if [[ "${{ matrix.ruby }}" == ruby-1.9* ]]; then
gem install json -v '2.2.0' --no-ri --no-rdoc
else
gem install json -v '2.2.0' --no-document
fi
- run: bundle --version
- run: bundle install
- run: bundle exec rake --version
Expand Down