Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 1.9 #7

Merged
merged 11 commits into from
Aug 1, 2021
Merged

Support Ruby 1.9 #7

merged 11 commits into from
Aug 1, 2021

Conversation

mullermp
Copy link
Contributor

Support building Ruby 1.9. Uses an appropriate OpenSSL version and removes usage of --no-document as it wasn't supported.

See ruby/setup-ruby#204

Build succeeded, but CI failed on Error: request to https://uploads.github.com/repos/ruby/ruby-builder/releases/33599578/assets?name=ruby-1.9.3-p551-ubuntu-18.04.tar.gz& failed, reason: socket hang up which is likely permissions related.

@@ -81,13 +81,23 @@ jobs:
run: |
if [ ! -e $PREFIX/bin/bundle ]; then
export PATH="$PREFIX/bin:$PATH"
gem install bundler -v '~> 1' --no-document
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted, we can alternatively just remove --no-document and don't branch at all.

@eregon eregon merged commit c306bbf into ruby:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants