Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building multiple JRuby versions at once #15

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Support building multiple JRuby versions at once #15

merged 1 commit into from
Nov 7, 2023

Conversation

jbaiza
Copy link
Contributor

@jbaiza jbaiza commented Nov 6, 2023

A build failed because two new JRuby versions were detected - https://github.com/ruby/ruby-builder/actions/runs/6767356671/job/18389860064.

I checked the build.yml file history and couldn't find why multiple JRuby versions could not be provided.

eregon
eregon approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this should work fine now. There used to be two keys in the matrix, ruby (e.g. jruby-9.1.2.3) and jruby-version (e.g. 9.1.2.3) and then if more than one version it would produce invalid combination.

@eregon eregon merged commit d15e308 into ruby:master Nov 7, 2023
@eregon eregon mentioned this pull request Nov 7, 2023
Closed
@jbaiza jbaiza deleted the multiple-jruby-versions branch November 8, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbaiza @eregon