-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add support for JRuby 9.3.12.0, 9.3.13.0, and 9.4.5.0 #544
Comments
It was very recently released, we need rbenv/ruby-build#2289 to be merged and then the automation https://github.com/ruby/ruby-builder/blob/master/.github/workflows/check-new-releases.yml to run |
@dentarg rbenv/ruby-build#2289 is now merged but the ruby-builder automation https://github.com/ruby/ruby-builder/actions/runs/6763182999/job/18380007387 failed with
|
Then we wait for maintainers to add it manually, maybe possible to help them with PRs to the builder repo and here. |
https://github.com/ruby/ruby-builder/ README says "Please report issues to ruby/setup-ruby" which is here 🙂 Are you the same maintainers' team or not? It was not clear to me where to report this automation failure... As I see @eregon added this commit ruby/ruby-builder@79d26f0 that does not allow to build several JRuby versions at once. It is not quite clear why it was added. If there are some limitations why it can't be done then probably in https://github.com/ruby/ruby-builder/blob/master/check-new-releases.rb#L53 sh("ruby", "build.rb", *new.map { |v| "#{engine}-#{v}" }) should be changed to if engine == 'jruby'
new.each do |v|
sh("ruby", "build.rb", "#{engine}-#{v}")
end
else
sh("ruby", "build.rb", *new.map { |v| "#{engine}-#{v}" })
end |
No, I'm not maintainer |
Thanks for the PR in ruby/ruby-builder#15 |
An error is returned when JRuby 9.3.13.0 is used:
We are using recommended
uses: ruby/setup-ruby@v1
.The text was updated successfully, but these errors were encountered: