Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for JRuby 9.3.12.0, 9.3.13.0, and 9.4.5.0 #544

Closed
jbaiza opened this issue Nov 3, 2023 · 7 comments
Closed

Please add support for JRuby 9.3.12.0, 9.3.13.0, and 9.4.5.0 #544

jbaiza opened this issue Nov 3, 2023 · 7 comments

Comments

@jbaiza
Copy link

jbaiza commented Nov 3, 2023

An error is returned when JRuby 9.3.13.0 is used:

Error: Unknown version 9.3.13.0 for jruby on ubuntu-22.04
        available versions for jruby on ubuntu-22.04: 9.1.17.0, 9.2.9.0, 9.2.10.0, 9.2.11.0, 9.2.11.1, 9.2.12.0, 9.2.13.0, 9.2.14.0, 9.2.15.0, 9.2.16.0, 9.2.17.0, 9.2.18.0, 9.2.19.0, 9.2.20.0, 9.2.20.1, 9.2.21.0, 9.3.0.0, 9.3.1.0, 9.3.2.0, 9.3.3.0, 9.3.4.0, 9.3.6.0, 9.3.7.0, 9.3.8.0, 9.3.9.0, 9.3.10.0, 9.3.11.0, 9.4.0.0, 9.4.1.0, 9.4.2.0, 9.4.3.0, 9.4.4.0, head

We are using recommended uses: ruby/setup-ruby@v1.

@dentarg
Copy link

dentarg commented Nov 3, 2023

@rsim
Copy link

rsim commented Nov 6, 2023

@dentarg rbenv/ruby-build#2289 is now merged but the ruby-builder automation https://github.com/ruby/ruby-builder/actions/runs/6763182999/job/18380007387 failed with

New releases for jruby: ["9.3.13.0", "9.4.5.0"]
ruby build.rb jruby-9.3.13.0 jruby-9.4.[5](https://github.com/ruby/ruby-builder/actions/runs/6763182999/job/18380007387#step:8:6).0
build.rb:24:in `<main>': More than 1 version not supported for JRuby (RuntimeError)
check-new-releases.rb:13:in `sh': ["ruby", "build.rb", "jruby-9.3.13.0", "jruby-9.4.5.0"] failed (RuntimeError)
	from check-new-releases.rb:53:in `block in <main>'
	from check-new-releases.rb:34:in `each_pair'
	from check-new-releases.rb:34:in `<main>'
Error: Process completed with exit code 1.

@dentarg
Copy link

dentarg commented Nov 6, 2023

Then we wait for maintainers to add it manually, maybe possible to help them with PRs to the builder repo and here.

@rsim
Copy link

rsim commented Nov 6, 2023

https://github.com/ruby/ruby-builder/ README says "Please report issues to ruby/setup-ruby" which is here 🙂 Are you the same maintainers' team or not? It was not clear to me where to report this automation failure...

As I see @eregon added this commit ruby/ruby-builder@79d26f0 that does not allow to build several JRuby versions at once. It is not quite clear why it was added. If there are some limitations why it can't be done then probably in https://github.com/ruby/ruby-builder/blob/master/check-new-releases.rb#L53

sh("ruby", "build.rb", *new.map { |v| "#{engine}-#{v}" })

should be changed to

if engine == 'jruby'
  new.each do |v|
    sh("ruby", "build.rb", "#{engine}-#{v}")
  end
else
  sh("ruby", "build.rb", *new.map { |v| "#{engine}-#{v}" })
end

@dentarg
Copy link

dentarg commented Nov 6, 2023

No, I'm not maintainer

@eregon
Copy link
Member

eregon commented Nov 7, 2023

Thanks for the PR in ruby/ruby-builder#15
Builds are running now: https://github.com/ruby/ruby-builder/actions/runs/6788294780

@eregon
Copy link
Member

eregon commented Nov 7, 2023

@eregon eregon closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants