Code

Prefix ids with table#1963

Code

Open

arbelt wants to merge 20 commits intorstudio:masterrstudio/gt:masterfrom arbelt:prefix-ids-with-table-idarbelt/gt:prefix-ids-with-table-idCopy head branch name to clipboard

Commits

Commits on Mar 5, 2025

• Merge pull request rstudio#1965 from rstudio/ci-remove-connect-deploy

  Show description for b235bc8
  rich-iannone

  authored
  b235bc8

  Copy full SHA for b235bc8

Commits on Mar 6, 2025

• initial add table_id

  arbelt

  committed
  349c59e

  Copy full SHA for 349c59e

• Add table_id parameter to render_row_data and update related functions

  arbelt

  committed
  a6a06e2

  Copy full SHA for a6a06e2

• Refactor ID attributes to use valid_html_id with tbl_id for improved HTML compliance

  arbelt

  committed
  17e09e8

  Copy full SHA for 17e09e8

• Refactor header construction in render_row_data for improved ID handling and HTML compliance

  arbelt

  committed
  addfce8

  Copy full SHA for addfce8

• Fix handling of current_group_id in render_row_data to support vector input and exclude NA values

  arbelt

  committed
  cb8309c

  Copy full SHA for cb8309c

• Fix: Avoid re-applying valid_html_id to row_id_i for stub cells in render_row_data

  arbelt

  committed
  2ef58be

  Copy full SHA for 2ef58be

• Refactor header component construction in render_row_data to separate unprefixed and prefixed IDs, ensuring valid_html_id is only applied where necessary.

  arbelt

  committed
  a3a6935

  Copy full SHA for a3a6935

• Refactor header creation in render_row_data to handle group IDs and column IDs individually, improving HTML compliance and clarity.

  arbelt

  committed
  e33199a

  Copy full SHA for e33199a

• Refactor render_row_data to improve group ID and row header ID handling, enhancing HTML compliance and clarity.

  arbelt

  committed
  c8d44fd

  Copy full SHA for c8d44fd

• Refactor render_row_data to improve header assignment logic, enhancing handling of group IDs and row boundaries for better HTML compliance.

  arbelt

  committed
  03bd760

  Copy full SHA for 03bd760

• Enhance valid_html_id function to check for NA values in tbl_id, ensuring robust ID generation.

  arbelt

  committed
  b8e27e2

  Copy full SHA for b8e27e2

• Refactor create_body_component_h to correctly handle row ID generation for two-column stubs, improving HTML compliance and clarity.

  arbelt

  committed
  d4b63ab

  Copy full SHA for d4b63ab

• Refactor render_row_data to streamline group ID handling, ensuring accurate cell-specific group IDs for improved HTML compliance and clarity.

  arbelt

  committed
  2a865c6

  Copy full SHA for 2a865c6

• update testing functions to accommodate prefixed element ids

  arbelt

  committed
  28c59dd

  Copy full SHA for 28c59dd

Commits on Mar 7, 2025

• use c to add stub indent class instead of paste

  arbelt

  committed
  4bbb51d

  Copy full SHA for 4bbb51d

• update snapshot for tab_stub_indent after extra_classes fix

  arbelt

  committed
  834be43

  Copy full SHA for 834be43

• Merge branch 'master' into prefix-ids-with-table-id

  arbelt

  authored
  d989bd9

  Copy full SHA for d989bd9

Commits on Mar 11, 2025

• don't manipulate or prefix empty ids in 'valid_html_id`

  Show description for cbbeb7a
  arbelt

  committed
  cbbeb7a

  Copy full SHA for cbbeb7a

• more meaningful tests

  arbelt

  committed
  86c21e7

  Copy full SHA for 86c21e7