Prefix ids with table #1963
Open
Prefix ids with table #1963
+5,868
−5,643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the PR. I didn't really review, but if you want the CI to pass, you will have to run tests locally and accept snapshot changes. i.e. with Also, you have to change the expected digest value in test-as_raw_html.R` for tests to pass. This is normal when we change the html code of a table. |
ci: remove Connect deployment
…ing and HTML compliance
… input and exclude NA values
… unprefixed and prefixed IDs, ensuring valid_html_id is only applied where necessary.
…olumn IDs individually, improving HTML compliance and clarity.
…ng, enhancing HTML compliance and clarity.
…g handling of group IDs and row boundaries for better HTML compliance.
…ring robust ID generation.
…n for two-column stubs, improving HTML compliance and clarity.
…curate cell-specific group IDs for improved HTML compliance and clarity.
arbelt
force-pushed
the
prefix-ids-with-table-id
branch
from
8ddd2c2 to
28c59dd
Compare
|
thanks! I've updated some of the testing code & accepted snapshots, so they should pass, but I didn't have a chance to review all the snapshot changes |
- fixes issues with empty spanners being assigned ids that were often duplicated
|
@olivroy I've scanned through the snapshot results and addressed any issues I saw, so I think it's about set — at least no todos pending on my list for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial implementation of prefixing element ids with the table id. This doesn't totally solve for potential duplicate IDs within a page, but should at least remove one of the most common sources (multiple tables with same column names).
This is a pretty big codebase. Happy to try to package this up more nicely but might need some pointers if there are interactions I'm missing.
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.