-
Notifications
You must be signed in to change notification settings - Fork 0
Dependency updates #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,16 @@ | ||
| - Always use curly braces `{}` for all control structures (if, else, for, foreach, while, etc.), even wrapping single-line statements. | ||
| - Insert a single blank line (CRLF) between method and function definitions. Adhere to StyleCop and commonly accepted C# formatting best practices throughout your code. | ||
| - Adhere to SOLID design principles and design patterns where applicable. | ||
| - Adhere to SOLID design principles and design patterns where applicable. Try to keep code elegant, clean, and succinct. | ||
| - Create interfaces for public classes, especially any that might be used for dependency injection. Add XML documentation comments to the interfaces with <inheritdoc/> on classes implementing the interface. | ||
| - Add XML documentation comments to all public interfaces (and classes, methods, and properties not covered by <inheritdoc/>. Ensure comments are meaningful and up to date. | ||
| - Prefix private fields in a class with an underscore (`_`) and use camelCase. | ||
| - Prefer asynchronous methods over synchronous/blocking methods. Avoid blocking calls such as `.Result` or `.Wait()` on tasks. | ||
| - Prefer asynchronous methods over synchronous/blocking methods. Avoid blocking calls such as `.Result`, `.Wait()`, `.GetAwaiter()`, etc. on tasks. | ||
| - Always use `.ConfigureAwait(false)` on awaited tasks unless it explicitly requires the synchronization context. | ||
| - Write unit tests using the MSTest framework. For mocking dependencies, use MOQ. If mocking requires dependency injection and a suitable mock isn’t available, use Autofac.Extras.Moq’s `AutoMock.GetLoose`. | ||
| - Use the `var` keyword for local variable declarations when the type is clear from the right-hand side of the assignment; otherwise, use the explicit type. | ||
| - Use the `nameof` operator when referencing identifiers (such as property names, method names, etc.), instead of hardcoded strings. | ||
| - Strive for small, single-responsibility methods. Refactor larger methods (>50 lines) into smaller pieces when practical. | ||
| - If a class contains many private methods, consider refactoring related functionality into separate classes to improve maintainability and cohesion. | ||
| - Use `IEnumerable<T>` or arrays for method parameters and return types when the collection is not intended to be modified. Use `List<T>` only when modification is required. | ||
| - Apply consistent exception handling practices across the codebase. Ensure that exceptions are meaningful, logged appropriately, and do not expose sensitive details. | ||
| - Apply consistent exception handling practices across the codebase. Ensure that exceptions are meaningful, logged appropriately, and do not expose sensitive details. | ||
| - Use Windows CRLF line endings for all code files. Ensure that your development environment is configured to use CRLF line endings to maintain consistency across the codebase. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.