Skip to content

Dependency updates - #14

Merged
rrusson merged 2 commits into
masterfrom
dependency-updates
Apr 18, 2026
Merged

Dependency updates#14
rrusson merged 2 commits into
masterfrom
dependency-updates

Conversation

@rrusson

@rrusson rrusson commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Upgrades

Copilot AI review requested due to automatic review settings April 18, 2026 19:28
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several NuGet dependencies across the solution and adjusts a few test assertions/attributes to align with the upgraded test/tooling stack.

Changes:

  • Bump multiple Microsoft.Extensions.*, ASP.NET Core, and Semantic Kernel package versions.
  • Update MSTest-related packages in ClippyWeb.Tests (including adding an ASP.NET Core shared framework reference).
  • Minor formatting/test assertion updates in a few C# files.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
TestConsole/TestConsole.csproj Bumps System.Configuration.ConfigurationManager patch version.
SharedInterfaces/SharedInterfaces.csproj Bumps Microsoft.Extensions.Configuration patch version.
SemanticKernelHelper/SemanticKernelHelper.csproj Updates SK + caching packages and adds Microsoft.Extensions.AI.
SemanticKernelHelper/ChatClientFactory.cs Adds a blank line (formatting only).
ClippyWeb/ClippyWeb.csproj Bumps Microsoft.AspNetCore.Mvc.NewtonsoftJson patch version.
ClippyWeb.Tests/Util/TcpClientWrapperTests.cs Switches async exception assertions to Assert.ThrowsAsync.
ClippyWeb.Tests/Util/ConnectionValidatorTests.cs Changes data-driven test attributes and async exception assertion.
ClippyWeb.Tests/SemanticKernelClientTests.cs Moves from [ExpectedException] to Assert.ThrowsExactly assertions.
ClippyWeb.Tests/ClippyWeb.Tests.csproj Updates test SDK/MSTest packages and adds Microsoft.AspNetCore.App framework reference.
.github/copilot-instructions.md Updates internal coding guidance (incl. line ending convention and async guidance).
Comments suppressed due to low confidence (4)

ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:40

  • [DataRow] is only supported on data-driven tests. With [TestMethod] here (and a parameterized method signature), MSTest test discovery will fail or the test will not run as intended. Switch this attribute back to [DataTestMethod] (or remove DataRow and make it a non-parameterized test).
		[TestMethod]
		[DataRow(null, DisplayName = "Null ServiceUrl")]
		[DataRow("", DisplayName = "Empty ServiceUrl")]
		public async Task IfServiceUrlIsNullOrEmptyThenLogsWarningAndReturns(string? serviceUrl)
		{

ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:56

  • [DataRow] requires [DataTestMethod]. Using [TestMethod] on a parameterized test method will break MSTest discovery/execution. Change this back to [DataTestMethod] (or remove the parameters + DataRows).
		[TestMethod]
		[DataRow("http://localhost:11434", DisplayName = "Localhost with port")]
		[DataRow("http://127.0.0.1:8080", DisplayName = "127.0.0.1 with port")]
		[DataRow("http://localhost", DisplayName = "Localhost without port")]
		[DataRow("https://localhost:443", DisplayName = "HTTPS URL")]

ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:76

  • This is still a data-driven test (uses [DataRow] and a string serviceUrl parameter), but the method is marked [TestMethod]. MSTest requires [DataTestMethod] for DataRows; otherwise discovery/execution fails.
		[TestMethod]
		[DataRow("http://example.com", DisplayName = "Remote host, no port")]
		[DataRow("http://example.com:8080", DisplayName = "Remote host with port")]
		[DataRow("http://testhost:5000", DisplayName = "Test host with port")]
		public async Task ValidateConnectionAsync_RemoteTest(string serviceUrl)

ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:93

  • [DataRow] isn't valid with [TestMethod], and this method has a required parameter. Convert this back to [DataTestMethod] so MSTest runs the DataRows (and test discovery doesn't fail).
		[TestMethod]
		[DataRow("not-a-valid-uri", DisplayName = "Invalid URI format")]
		[DataRow("   ", DisplayName = "Whitespace only")]
		public async Task IfServiceUrlIsInvalidUriThenThrowsException(string serviceUrl)
		{

Comment thread .github/copilot-instructions.md
@rrusson
rrusson merged commit b24ee2d into master Apr 18, 2026
7 checks passed
@rrusson
rrusson deleted the dependency-updates branch April 18, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants