Dependency updates - #14
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several NuGet dependencies across the solution and adjusts a few test assertions/attributes to align with the upgraded test/tooling stack.
Changes:
- Bump multiple
Microsoft.Extensions.*, ASP.NET Core, and Semantic Kernel package versions. - Update MSTest-related packages in
ClippyWeb.Tests(including adding an ASP.NET Core shared framework reference). - Minor formatting/test assertion updates in a few C# files.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TestConsole/TestConsole.csproj | Bumps System.Configuration.ConfigurationManager patch version. |
| SharedInterfaces/SharedInterfaces.csproj | Bumps Microsoft.Extensions.Configuration patch version. |
| SemanticKernelHelper/SemanticKernelHelper.csproj | Updates SK + caching packages and adds Microsoft.Extensions.AI. |
| SemanticKernelHelper/ChatClientFactory.cs | Adds a blank line (formatting only). |
| ClippyWeb/ClippyWeb.csproj | Bumps Microsoft.AspNetCore.Mvc.NewtonsoftJson patch version. |
| ClippyWeb.Tests/Util/TcpClientWrapperTests.cs | Switches async exception assertions to Assert.ThrowsAsync. |
| ClippyWeb.Tests/Util/ConnectionValidatorTests.cs | Changes data-driven test attributes and async exception assertion. |
| ClippyWeb.Tests/SemanticKernelClientTests.cs | Moves from [ExpectedException] to Assert.ThrowsExactly assertions. |
| ClippyWeb.Tests/ClippyWeb.Tests.csproj | Updates test SDK/MSTest packages and adds Microsoft.AspNetCore.App framework reference. |
| .github/copilot-instructions.md | Updates internal coding guidance (incl. line ending convention and async guidance). |
Comments suppressed due to low confidence (4)
ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:40
[DataRow]is only supported on data-driven tests. With[TestMethod]here (and a parameterized method signature), MSTest test discovery will fail or the test will not run as intended. Switch this attribute back to[DataTestMethod](or removeDataRowand make it a non-parameterized test).
[TestMethod]
[DataRow(null, DisplayName = "Null ServiceUrl")]
[DataRow("", DisplayName = "Empty ServiceUrl")]
public async Task IfServiceUrlIsNullOrEmptyThenLogsWarningAndReturns(string? serviceUrl)
{
ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:56
[DataRow]requires[DataTestMethod]. Using[TestMethod]on a parameterized test method will break MSTest discovery/execution. Change this back to[DataTestMethod](or remove the parameters + DataRows).
[TestMethod]
[DataRow("http://localhost:11434", DisplayName = "Localhost with port")]
[DataRow("http://127.0.0.1:8080", DisplayName = "127.0.0.1 with port")]
[DataRow("http://localhost", DisplayName = "Localhost without port")]
[DataRow("https://localhost:443", DisplayName = "HTTPS URL")]
ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:76
- This is still a data-driven test (uses
[DataRow]and astring serviceUrlparameter), but the method is marked[TestMethod]. MSTest requires[DataTestMethod]for DataRows; otherwise discovery/execution fails.
[TestMethod]
[DataRow("http://example.com", DisplayName = "Remote host, no port")]
[DataRow("http://example.com:8080", DisplayName = "Remote host with port")]
[DataRow("http://testhost:5000", DisplayName = "Test host with port")]
public async Task ValidateConnectionAsync_RemoteTest(string serviceUrl)
ClippyWeb.Tests/Util/ConnectionValidatorTests.cs:93
[DataRow]isn't valid with[TestMethod], and this method has a required parameter. Convert this back to[DataTestMethod]so MSTest runs the DataRows (and test discovery doesn't fail).
[TestMethod]
[DataRow("not-a-valid-uri", DisplayName = "Invalid URI format")]
[DataRow(" ", DisplayName = "Whitespace only")]
public async Task IfServiceUrlIsInvalidUriThenThrowsException(string serviceUrl)
{
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Upgrades