Skip to content

Add structured parameter support #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Add structured parameter support #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions rcl_interfaces/msg/ParameterType.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ uint8 PARAMETER_BOOL=1
uint8 PARAMETER_INTEGER=2
uint8 PARAMETER_DOUBLE=3
uint8 PARAMETER_STRING=4
uint8 PARAMETER_BYTE_ARRAY=5
uint8 PARAMETER_BOOL_ARRAY=6
uint8 PARAMETER_INTEGER_ARRAY=7
uint8 PARAMETER_DOUBLE_ARRAY=8
uint8 PARAMETER_STRING_ARRAY=9
uint8 PARAMETER_YAML=5
Copy link

@jmachowinski jmachowinski Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue: I would make the new value 10, in this way you have at least some backward compatibility...

uint8 PARAMETER_BYTE_ARRAY=6
uint8 PARAMETER_BOOL_ARRAY=7
uint8 PARAMETER_INTEGER_ARRAY=8
uint8 PARAMETER_DOUBLE_ARRAY=9
uint8 PARAMETER_STRING_ARRAY=10
3 changes: 3 additions & 0 deletions rcl_interfaces/msg/ParameterValue.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ float64 double_value
# A textual value with no practical length limit.
string string_value

# A yaml string with a current upper limit of (100Kb) enforced by RCL
string yaml_value

# An array of bytes, used for non-textual information.
byte[] byte_array_value

Expand Down