Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add galois to python.yaml #44829

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Add galois to python.yaml #44829

merged 2 commits into from
Mar 27, 2025

Conversation

Silviis
Copy link
Contributor

@Silviis Silviis commented Mar 19, 2025

Please add the following dependency to the rosdep database.

Package name:

python3-galois-pip

Package Upstream Source:

https://github.com/mhostetter/galois

Purpose of using this:

A performant NumPy extension for Galois fields and their applications

Distro packaging links:

Links to Distribution Packages

Package not found in most distros package manager. It can be found in PyPI: https://pypi.org/project/galois/

@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Mar 19, 2025
@Silviis Silviis marked this pull request as ready for review March 19, 2025 09:52
@Silviis Silviis requested a review from a team as a code owner March 19, 2025 09:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@christophebedard
Copy link
Member

Standard pip disclaimer: ROS packages that depend on pip keys cannot be released into a ROS distribution. They can only be depended on by from-source builds. Because of this, system packages are highly preferred to pip packages.

I indeed couldn't find this for Ubuntu or Debian (note that this is not the same package: https://packages.ubuntu.com/noble/galois).

@quarkytale quarkytale merged commit cfdf128 into ros:master Mar 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants