This repository was archived by the owner on May 31, 2025. It is now read-only.
Fix how generated headers are added to the include search path#173
Closed
poggenhans wants to merge 1 commit intoros:noetic-develfrom
Closed
Fix how generated headers are added to the include search path#173poggenhans wants to merge 1 commit intoros:noetic-develfrom
poggenhans wants to merge 1 commit intoros:noetic-develfrom
Conversation
Headers are now added at the start of the system include search path as intended instead of at the end
Contributor
|
Fixed by #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
include_directoriescommand is used incorrectly. TheBEFOREhas to go before theSYSTEM: https://cmake.org/cmake/help/latest/command/include_directories.html.With the current implementation, the the actual directory and a non-existing directory
BEFOREare instead added to the end.