Make C++ Config instances have default values in constructor#107
Make C++ Config instances have default values in constructor#107lucasw wants to merge 1 commit intoros:noetic-develfrom
Conversation
|
Sorry @lucasw for the wait and thanks for the contribution!
There doesn't seem to be an no option to disable them in dynamic_reconfigure ATM.
👍 A unit test for this would be great
Yeah it would make sense to have the symmetric in Python, though it shouldn't block the C++ version from moving forward as there is an easy way to get them @ros-pull-request-builder retest this please |
|
What's the status on this? |
941fb7d to
2795b6d
Compare
|
Rebased this on |
…w, haven't looked at python ros#33
2795b6d to
6c39635
Compare
|
Thank you for the PR! Unfortunately I don't think we should merge this one. ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. I'm closing pull requests that add features so that the remaining time is allocated towards bug fixes and compatibility with newer Ubuntu distros. |
This generates a header with an initializer list with all the default values, previously the defaults were loaded in only when the server ran.
This works now:
For #33
(There isn't a corresponding class created for python (would that be useful?), the defaults can be accessed currently like this:
)