Skip to content

Conversation

EricoMeger
Copy link

Basic Info

Info Please fill out this column
Ticket(s) this addresses #5595
Primary OS tested on Ubuntu 24.04
Robotic platform tested on Physical Robot (differential-drive)
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

  • Fixes a bug in RPP where the robot would "creep" forward after stopping for an obstacle if min_lookahead was set lower than min_distance_to_obstacle
  • Change isCollisionImminent logic to always cover at least up to min_distance_to_obstacle, even when carrot_dist shrinks.

Description of documentation updates required from your changes

None

Description of how this change was tested

Tested for a week on a physical differential-drive robot using a 270-degree LiDAR in a real-world environment. The tests included various routes with both static and dynamic obstacles placed in the robot's path. No negative side effects or degradation in general navigation behavior were observed.


Future work that may be required in bullet points

I don't like to create a entire new variable just that it receives carrot_dist if min_distance_to_obstacle is unused, but I can't think of a better way to do that. I'm open to suggestions.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit for wording, LGTM. Check out the CI issues, it looksl ike you have linting violations that need to be resolved before merge

@doisyg please approve as well

EricoMeger and others added 2 commits October 10, 2025 18:31
Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Érico Meger <[email protected]>
Signed-off-by: EricoMeger <[email protected]>
@EricoMeger EricoMeger changed the title prevent collision check premature termination [RPP] Prevent collision check premature termination Oct 10, 2025
@EricoMeger
Copy link
Author

Just updated the title to add the [RPP] prefix, to make the PR more self-explanatory

Copy link
Contributor

mergify bot commented Oct 10, 2025

@EricoMeger, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants