Controller FollowPath feedback: Fix wrong frame in distance calculation, add more info to feedback #4931
+31
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
closest_path_pose_idx
anddistance_to_path
to the feedbacknav2_behavior_tree/nav2_tree_nodes.xml
Description of documentation updates required from your changes
none (?)
Description of how this change was tested
Tested on a Gazebo simulation of our robot, using Jazzy (same commits, just based on jazzy)
Future work that may be required in bullet points
Open question for discussion: Should the feedback from the
FollowPath
action be written into the Blackboard in the BT action node (follow_path_action
)?Write FollowPath Feedback to blackboard
(reverted for now)For Maintainers: