Switch nav2_rviz_plugins to modern CMake idioms. #4600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, make some fixes to the code to more appropriately hold on to the Node object (there were warnings from the compiler without these fixes).
Basic Info
Description of contribution in a few bullet points
Change nav2_rviz_plugins to use modern CMake idioms:
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is part of a larger series to switch Navigation2 to use modern CMake idioms. There will be follow-up PRs converting more of the packages.
For Maintainers: