Skip to content

Cleanup deprecations in diff_drive_controller #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2025

Conversation

christophfroehlich
Copy link
Contributor

No description provided.

@christophfroehlich christophfroehlich added the hold Holding off merging this PR until some condition label Apr 22, 2025
@christophfroehlich christophfroehlich changed the base branch from add/kilted to branch/jazzy April 22, 2025 19:52
@ros-controls ros-controls deleted a comment from mergify bot Apr 22, 2025
saikishor
saikishor previously approved these changes Apr 22, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich deleted the branch master May 12, 2025 18:49
@github-project-automation github-project-automation bot moved this from Kilted to Done in Roadmap / Features May 12, 2025
@christophfroehlich christophfroehlich changed the base branch from branch/jazzy to master May 16, 2025 15:14
@christophfroehlich christophfroehlich dismissed saikishor’s stale review May 16, 2025 15:14

The base branch was changed.

Copy link
Contributor

mergify bot commented May 16, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich moved this from Done to Kilted in Roadmap / Features May 16, 2025
@christophfroehlich christophfroehlich removed the hold Holding off merging this PR until some condition label May 16, 2025
@christophfroehlich christophfroehlich merged commit a118def into master May 17, 2025
20 of 26 checks passed
@github-project-automation github-project-automation bot moved this from Kilted to Done in Roadmap / Features May 17, 2025
@christophfroehlich christophfroehlich deleted the cleanup/diff_drive branch May 17, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants