Skip to content

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Sep 29, 2025

Needs ros-controls/ros2_controllers#1936 to be merged first

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.44%. Comparing base (e8f8c01) to head (0803afc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
+ Coverage   89.42%   89.44%   +0.02%     
==========================================
  Files         151      151              
  Lines       17036    17027       -9     
  Branches     1412     1412              
==========================================
- Hits        15234    15230       -4     
+ Misses       1243     1237       -6     
- Partials      559      560       +1     
Flag Coverage Δ
unittests 89.44% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/hardware_interface/hardware_component.hpp 100.00% <ø> (ø)
...ardware_interface/hardware_component_interface.hpp 77.69% <100.00%> (-0.16%) ⬇️
...de/hardware_interface/loaned_command_interface.hpp 52.63% <ø> (ø)
...lude/hardware_interface/loaned_state_interface.hpp 57.69% <ø> (ø)
hardware_interface/src/hardware_component.cpp 79.79% <ø> (+3.09%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich marked this pull request as ready for review October 1, 2025 22:04
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Just few nitpicks

Co-authored-by: Sai Kishor Kothakota <[email protected]>
@christophfroehlich christophfroehlich moved this from Kilted to ROS-L in Roadmap / Features Oct 2, 2025
Copy link
Contributor

mergify bot commented Oct 3, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich merged commit 8c6e2e9 into master Oct 15, 2025
15 of 17 checks passed
@christophfroehlich christophfroehlich deleted the cleanup/deprecations branch October 15, 2025 13:54
@github-project-automation github-project-automation bot moved this from ROS-L to Done in Roadmap / Features Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants