-
Notifications
You must be signed in to change notification settings - Fork 247
Use msgpack for API #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use msgpack for API #1176
Conversation
|
JJ doesn't support git submodules 😢 |
|
I'm not sure if the tests are correct because some tests seem to run infinitely. There is also this code in serve_utils that uses json. Not sure what this is for or if it needs to be updated. Ok(Message::Text(text)) => {
let packet: SocketPacket = serde_json::from_str(&text)?;
if packet.packet_type != packet_type {
continue;
}
// Close the WebSocket connection now that we got what we were waiting for
let _ = socket.close(None);
return Ok(packet);
}EDIT: Fixed |
|
The |
plugin/src/Reconciler/diff.lua
Outdated
|
|
||
| -- For NaN, check if both values are not equal to themselves | ||
| elseif a ~= a and b ~= b then | ||
| print("they are equal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spare print statement you may want to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks.
|
Note: There's weird failure modes for when plugin/rojo are out of sync here. |
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Switches the rojo API to use msgpack instead of JSON. Fixes rojo-rbx#363. Fixes rojo-rbx#881.
Switches the rojo API to use msgpack instead of JSON.
Fixes #363.
Fixes #881.