Slightly improve initial sync hangs #1140
Merged
+81
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
added
scope: plugin
Dekkonot
approved these changes
Nov 5, 2025
| local getProperty = require(Plugin.Reconciler.getProperty) | ||
|
|
||
| local function yieldIfNeeded(clock) | ||
| if os.clock() - clock > 1 / 20 then |
Member
There was a problem hiding this comment.
1/20 of a second feels like an arbitrary time. task.wait() is something like 1/30th of a second, right?
Member
Author
There was a problem hiding this comment.
It's actually just to the next Heartbeat, which could be 1/240th of a second. You're thinking of the old wait(). 1/20 is arbitrary, but I played with a couple values and this one felt like a good balance between slowing it down and making it not freeze up.
Contributor
|
See #1176 for potential fix on performance in terms of total data throughput |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the hang is actually just
HttpService:JSONDecodetaking ages on massive trees.This PR does not address that problem. It does, however, make a couple small improvements.
Demo.mp4