RbxReadInterleaved Trait #592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ReadSlice trait within interleaved readers to avoid an intermediate allocation. Group the read_interleaved_* functions into a dedicated trait.
Notes:
use<Self>syntax is no longer needed.Performance
Not seeing any significant performance changes :(
Lore
Previously this was part of #530 but I've separated it out since it's a distinct change. I had to list it with a comma in the PR title for goodness sake. #561 Is a past version of this same change, but it's less developed and duplicates changes from #530.