Add read_array method to ReadSlice trait
#575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Micah <[email protected]>
Utilize ToOwned to copy strings when necessary.
the split_at can panic, there is a checked variant if it should be handled gracefully
This reverts commit 030f68a.
This reverts commit 6b5ac80.
Required to remove the Read trait bound from RbxReadExt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the diff without prereqs here: krakow10/rbx-dom@read-slice_zero-copy...3bd7126
Add a const-generic method to read a fixed-length array from a slice. I really like how all the RbxReadExt methods are able to use the new method. The RbxReadExt trait is changed to only depend on ReadSlice rather than Read. This means that, after decompressing the chunk, all reading in deserializer/state.rs is done from the ReadSlice trait. ChunkHeader and FileHeader are read before the chunk is decompressed which is why the code has to be changed.