Skip to content

Preserve restored viewports and crisp source pixels - #139

Merged
lucas-fochesatto merged 3 commits into
mainfrom
lucas/dataman-467-pixel-inspection
Oct 12, 2026
Merged

lucas-fochesatto merged 3 commits into
mainfrom
lucas/dataman-467-pixel-inspection

Conversation

@lucas-fochesatto

@lucas-fochesatto lucas-fochesatto commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Precision annotation needs exact locked view restoration and distinct source pixels at high zoom; explicit viewport updates now preserve valid requested transforms, and the public pixel-inspection option keeps zoomed media crisp at the configured display resolution.

Type of Change

  • Bug fix
  • New feature

Validation

  • Tests added or updated where behavior changed
  • Documentation updated where the public API or workflow changed
  • Screenshots or recording attached for visual changes
  • Full npm run verify passed: 3,359 Vitest tests plus boundary, docs, packaging, demo and benchmark checks/builds.
  • Chromium/WebGPU: 8 native/proxy DPR 1/2 captures match baseline RGBA; display sampling is preserved after capture and extraction errors.
  • Actual editor in local Chromium: locked navigation across different media sizes, controls/reset, wheel anchors and DPR 1/2 passed; screenshot pixels contain only source colors at high zoom.

Notes For Reviewers

  • GPU captures preserve baseline pixels independently of pixel inspection, retaining existing dimensions and DPR behavior.
  • pixelInspection.minScale uses CSS pixels per natural media pixel; smooth sampling remains the default. Display filters inherit the configured render resolution.
  • Explicit setters accept positive finite scales outside gesture bounds while locked; pan/wheel gestures retain lock and bounds, including fractional offsets.

@lucas-fochesatto
lucas-fochesatto requested a review from a team as a code owner October 12, 2026 02:56
@lucas-fochesatto lucas-fochesatto changed the title [DATAMAN-467] Preserve restored viewports and crisp source pixels Preserve restored viewports and crisp source pixels Oct 12, 2026

@joaomarcoscrs joaomarcoscrs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-fochesatto
lucas-fochesatto merged commit e7e8010 into main Oct 12, 2026
3 checks passed
@lucas-fochesatto
lucas-fochesatto deleted the lucas/dataman-467-pixel-inspection branch October 12, 2026 17:59
@lucas-fochesatto lucas-fochesatto mentioned this pull request Oct 12, 2026
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants