Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a taskbar to the UI, new polygon functionalities and some bugfixes #11

Merged
merged 16 commits into from
Aug 21, 2024

Conversation

lrosemberg
Copy link

@lrosemberg lrosemberg commented Aug 16, 2024

Description

Check here the new features and bugfixes (video - 2 min):
https://share.cleanshot.com/3zdWX7rZ

CleanShot 2024-08-16 at 21 01 39@2x

Hello, I created a user interface for the application, and fixed some bugs I found while I was developing.
This PR is an addition to the changes contained in my previous PR as well (#10)

In this PR the following changes were made:

  • Inserted a new taskbar, which allows access to the following functions: Polygon mode, Line mode, Undo, Discard current, Clear all polygons and Save image
  • I remade the coordinate menu
  • When you click on the start point when drawing a polygon, the polygon is completed, without the need to press enter
  • I adjusted the spacing of the sections
  • I simplified some logics

In addition, I fixed the following bugs:

  • When scrolling to zoom in, the page scrolled together
  • In line insertion mode, the logic was wrong and did not draw the second arc at the end point of the line

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Docs

  • Docs updated? What were the changes:

@lrosemberg lrosemberg changed the title Taskbar Added a taskbar to the UI, new polygon functionalities and some bugfixes Aug 17, 2024
@lrosemberg
Copy link
Author

Hello, this PR contains the changes made previously in #10, because I needed some existing codes in the previous PR and would not like to open a single giant PR.

@capjamesg @yeldarby

@mwomick mwomick mentioned this pull request Aug 17, 2024
2 tasks
@capjamesg
Copy link
Collaborator

Great work! I love the feature where you can click on the origin point on the polygon to complete the polygon.

One note: When I tested this on my Macbook Air at full resolution, I see some overflow out of the main container:

Screenshot 2024-08-19 at 08 46 07

Can you update the styles so that the page stays within the viewport container?

Copy link
Collaborator

@capjamesg capjamesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See my comment on the overflow of the main container. After that point has been addressed, I can merge this PR.

@lrosemberg
Copy link
Author

Looks good! See my comment on the overflow of the main container. After that point has been addressed, I can merge this PR.

Hey @capjamesg, I fixed that and other css minor tweaks, can you check please?

Copy link
Collaborator

@capjamesg capjamesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page works well on desktop at different resolutions now. I'm going to merge this PR.

@capjamesg capjamesg merged commit db9a898 into roboflow:main Aug 21, 2024
@capjamesg
Copy link
Collaborator

Thank you for your contribution! The user experience Polygon Zone is significantly better than it was!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants