Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed there were a couple unexpected behaviors of this app and some missing features that are ubiquitous among similar apps--annotation products, vector graphics editors, presentation software, etc.
Unexpected behaviors included:
Missing features included:
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Since the changes were mostly UI-related, the changes were tested by using the web app in Safari and Chrome. For example, after I added the undo feature, I tested it by trying to draw a polygon and undoing point additions until the shape disappeared and then re-drawing and re-undoing the polygon to test for consistency. I also added lines (not undoable at this point) and then polygons and then tested to make sure switching modes (line/polygon) did not affect the feature.
Any specific deployment considerations
Since this is a static web page and is deployed on GitHub, it might be worth considering that the code is readable and the comments in the code are viewable by the end user. Since the code base is small, this is negligible on performance (i.e. content delivery), but it might be a cause of concern depending on Roboflow's expectation for production polish and style.